Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation error #430

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fix documentation error #430

merged 1 commit into from
Jan 19, 2017

Conversation

vjon
Copy link
Contributor

@vjon vjon commented Jan 18, 2017

In the main Readme, in the "STL-like access" subsection of the "Examples", move the comparison before "j.clear()" function call, such that the intended return value "true" is actually correct.

Fix documentation error
046f6da 
Move comparison before "j.clear()" function call, such that the intended return value "true" is actually correct.
@nlohmann nlohmann added this to the Release 2.0.11 milestone Jan 18, 2017
nlohmann
nlohmann approved these changes Jan 18, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 046f6da on vjon:patch-1 into bae8e70 on nlohmann:develop.

@nlohmann nlohmann merged commit e951d19 into nlohmann:develop Jan 19, 2017
@nlohmann nlohmann self-assigned this Jan 19, 2017
@nlohmann
Copy link
Owner

Thanks!

@vjon vjon deleted the patch-1 branch January 19, 2017 17:40
@nlohmann nlohmann modified the milestones: Release 2.0.11, Release 2.1.0 Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation
Projects
None yet
Milestone
Release 2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vjon @coveralls @nlohmann