-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bazel): add MODULE.bazel files for bzlmod #4314
base: develop
Are you sure you want to change the base?
Conversation
Is adding file |
To my understanding this will at least avoid generate a patch file every time a new release is published to the BCR. Having this file in the repository seems to be a trouble, can you explain why ? |
I personally do not maintain any of the package manager integrations. Hence I am reluctant to having these files in the repository. |
@Vertexwahn did the configuration in the BCR maybe he has an opinion on that. |
@mmorel-35 I proposed to add a I personally would suggest to add a In the current state of Bazel (7.x) we need a Currently, we are in a transition phase from Bazel 7 -> 8 (maybe end of this year) -> 9 (maybe end of next year) - i.e. it will take some time until we can remove the WORKSPACE file. @nlohmann For me it seems that there are people around that care about the Catch2 Bazel support. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
Integrate MODULE.bazel from https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/nlohmann_json
Then it shall be possible to publish automatically with the new version with the help of bcr bot : https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#contribute-a-bazel-module
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filessingle_include/nlohmann/json.hpp
andsingle_include/nlohmann/json_fwd.hpp
. The whole process is described here.Please don't
#ifdef
s or other means.