Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwork documentation #4516

Merged
merged 53 commits into from
Dec 9, 2024
Merged

Overwork documentation #4516

merged 53 commits into from
Dec 9, 2024

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Nov 25, 2024 •
edited
Loading

Closes #4026. Closes #4289. Closes #4279.

@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Coverage Status

coverage: 99.649%. remained the same
when pulling 7da52e9 on documentation-updates
into 9f60e85 on develop.

gregmarr
gregmarr reviewed Nov 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CMake label Nov 30, 2024
@github-actions github-actions bot removed the tests label Nov 30, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 5, 2024
@nlohmann nlohmann marked this pull request as ready for review December 7, 2024 22:24
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Dec 7, 2024
@nlohmann nlohmann requested a review from gregmarr December 7, 2024 22:25
gregmarr
gregmarr reviewed Dec 9, 2024
View reviewed changes
docs/mkdocs/docs/api/basic_json/emplace_back.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/basic_json/index.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/basic_json/index.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/basic_json/insert.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/basic_json/insert.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/api/ordered_json.md Outdated Show resolved Hide resolved
docs/mkdocs/docs/features/assertions.md Outdated Show resolved Hide resolved
@nlohmann nlohmann requested a review from gregmarr December 9, 2024 19:44
gregmarr
gregmarr approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@gregmarr gregmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small redundancy, otherwise looks good.

docs/mkdocs/docs/api/basic_json/emplace_back.md Outdated Show resolved Hide resolved
@nlohmann nlohmann merged commit 549c79b into develop Dec 9, 2024
121 checks passed
@nlohmann nlohmann deleted the documentation-updates branch December 9, 2024 22:02
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@nlohmann @slowriot
Overwork documentation (nlohmann#4516)
540f9ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees
No one assigned
Labels
CI CMake documentation L review needed It would be great if someone could review the proposed changes.
Projects
None yet
Milestone
Release 3.11.4
3 participants
@nlohmann @coveralls @gregmarr