Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token permissions warnings #4550

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Fix token permissions warnings #4550

merged 3 commits into from
Dec 17, 2024

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 17, 2024 •
edited
Loading

Warnings from https://scorecard.dev/viewer/?uri=github.com/nlohmann/json:

  • Info: jobLevel 'contents' permission set to 'read': .github/workflows/comment_check_amalgamation.yml:15
  • Info: jobLevel 'actions' permission set to 'read': .github/workflows/comment_check_amalgamation.yml:16
  • Info: jobLevel 'issues' permission set to 'read': .github/workflows/comment_check_amalgamation.yml:17
  • Info: jobLevel 'contents' permission set to 'read': .github/workflows/labeler.yml:12
  • Info: jobLevel 'actions' permission set to 'read': .github/workflows/scorecards.yml:30
  • Info: jobLevel 'issues' permission set to 'read': .github/workflows/scorecards.yml:32
  • Info: jobLevel 'pull-requests' permission set to 'read': .github/workflows/scorecards.yml:33
  • Info: jobLevel 'checks' permission set to 'read': .github/workflows/scorecards.yml:35
  • Info: jobLevel 'contents' permission set to 'read': .github/workflows/scorecards.yml:29
  • Info: jobLevel 'contents' permission set to 'read': .github/workflows/ubuntu.yml:133
  • Warn: jobLevel 'checks' permission set to 'write': .github/workflows/ubuntu.yml:134
  • Info: topLevel permissions set to 'read-all': .github/workflows/check_amalgamation.yml:6
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/cifuzz.yml:5
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/codeql-analysis.yml:15
  • Info: found token with 'none' permissions: .github/workflows/comment_check_amalgamation.yml:1
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/dependency-review.yml:13
  • Info: found token with 'none' permissions: .github/workflows/labeler.yml:1
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/macos.yml:13
  • Warn: topLevel 'contents' permission set to 'write': .github/workflows/publish_documentation.yml:14
  • Info: topLevel permissions set to 'read-all': .github/workflows/scorecards.yml:18
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/ubuntu.yml:13
  • Info: topLevel 'contents' permission set to 'read': .github/workflows/windows.yml:13

@coveralls
Copy link

Coverage Status

coverage: 99.634%. remained the same
when pulling afa99e6 on fix-warnings
into f4910b2 on develop.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 17, 2024
@nlohmann nlohmann merged commit 861ec9c into develop Dec 17, 2024
122 checks passed
@nlohmann nlohmann deleted the fix-warnings branch December 17, 2024 11:55
slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
@nlohmann @slowriot
Fix token permissions warnings (nlohmann#4550)
8399284 
* 🚨 fix token permissions warnings

* 🚨 fix token permissions warnings

* 🚨 fix token permissions warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI M
Projects
None yet
Milestone
Release 3.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls