Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doxygen error of basic_json::get() #583

Merged
merged 2 commits into from
May 15, 2017
Merged

fix doxygen error of basic_json::get() #583

merged 2 commits into from
May 15, 2017

Conversation

zhaohuaxishi
Copy link

@ref command do not seems to work in markdown code span. so i change

`void from_json(const  @ref basic_json&, ValueType&)`

into

`void from_json(const ` @ref basic_json`&, ValueType&)`

are there better solution for this problem?

@nlohmann
Copy link
Owner

The mentioned functions are not meant to be linked in the first place, because they are most likely in the client's code - it can be any from_json function based on ValueType. I'm not sure whether fixing this so that basic_json can be clicked brings too much value here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling dfa371c on zhaohuaxishi:doxygen_error into 9b764ee on nlohmann:develop.

@zhaohuaxishi
Copy link
Author

is that means the @ref command should just be removed then.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling b8dff3b on zhaohuaxishi:doxygen_error into 723c875 on nlohmann:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.722% when pulling b8dff3b on zhaohuaxishi:doxygen_error into 723c875 on nlohmann:develop.

@nlohmann nlohmann self-assigned this May 14, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone May 14, 2017
@nlohmann nlohmann merged commit 0f4131d into nlohmann:develop May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants