Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for the vcpkg package. #753

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Add info for the vcpkg package. #753

merged 1 commit into from
Sep 26, 2017

Conversation

gregmarr
Copy link
Contributor

This adds the information on the package for this library in the vcpkg package manager, and fixes a typo in the description of the hunter package name.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ec60ff3 on gregmarr:patch-1 into 647711f on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Sep 26, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Sep 26, 2017
@nlohmann nlohmann merged commit b05ea3d into nlohmann:develop Sep 26, 2017
@nlohmann
Copy link
Owner

Thanks!!

@nlohmann
Copy link
Owner

nlohmann commented Jul 1, 2018

@gregmarr Do you have experiences using vcpkg. I am currently overworking the documentation and did not manage to build a small CMake project which works with the header installed via vcpkg install nlohmann-json.

@ras0219-msft
Copy link

@nlohmann vcpkg doesn't add all installed libraries to your include/link/etc paths by default, so you'll need to use standard cmake commands to find and add the header:

find_path(NLOHMANN_JSON_DIR NAMES nlohmann/json.hpp)
include_directories(${NLOHMANN_JSON_DIR})

@nlohmann
Copy link
Owner

nlohmann commented Jul 4, 2018

Thanks a lot! That helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants