Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using more CMake #765

Merged
merged 25 commits into from
Oct 4, 2017
Merged

using more CMake #765

merged 25 commits into from
Oct 4, 2017

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Oct 3, 2017

Done:

  • using CMake for the special targets Valgrind (JSON_Valgrind), Clang sanitizers (JSON_Sanitizer), and no-exceptions (JSON_NoExceptions)
  • using Ninja to improve compilation speed
  • compiling and executing each test suite individually
  • removed test cases that broke the MSVC 2017 build

Missing:

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 3, 2017

(This should fix #698)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e2045ea on feature/issue698 into 7435d54 on develop.

@nlohmann
Copy link
Owner Author

nlohmann commented Oct 4, 2017

@theodelrieu Would it be OK if I merged this PR tonight?

@theodelrieu
Copy link
Contributor

Sure! Even now if you want

@nlohmann nlohmann merged commit 4e81c1d into develop Oct 4, 2017
@nlohmann nlohmann self-assigned this Oct 4, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Oct 4, 2017
@nlohmann nlohmann deleted the feature/issue698 branch October 4, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants