Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hunter package links #829

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Updated hunter package links #829

merged 2 commits into from
Nov 18, 2017

Conversation

jowr
Copy link
Contributor

@jowr jowr commented Nov 15, 2017

The broken links to the hunter package confused me, but I found the package now. This fixes #828.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b5ddd99 on jowr:patch-1 into 4c4f60f on nlohmann:develop.

README.md Outdated
@@ -7,6 +7,7 @@
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/f3732b3327e34358a0e9d1fe9f661f08)](https://www.codacy.com/app/nlohmann/json?utm_source=github.com&utm_medium=referral&utm_content=nlohmann/json&utm_campaign=Badge_Grade)
[![Try online](https://img.shields.io/badge/try-online-blue.svg)](https://wandbox.org/permlink/yCTCvQi0ZVxGuL3L)
[![Documentation](https://img.shields.io/badge/docs-doxygen-blue.svg)](http://nlohmann.github.io/json)
[![Hunter package](https://img.shields.io/badge/hunter-nlohmann_json-blue.svg)](https://docs.hunter.sh/en/latest/packages/pkg/nlohmann_json.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add a badge for Hunter. This is too prominent, and there are many other package managers.

@jowr
Copy link
Contributor Author

jowr commented Nov 16, 2017

Alright, as you wish :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7b8ddad on jowr:patch-1 into 4c4f60f on nlohmann:develop.

@nlohmann nlohmann self-assigned this Nov 18, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Nov 18, 2017
@nlohmann nlohmann merged commit 52ca35b into nlohmann:develop Nov 18, 2017
@nlohmann
Copy link
Owner

Thanks!

@jowr jowr deleted the patch-1 branch November 19, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CMake hunter package?
3 participants