-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overworked library toward 3.0.0 release #875
Conversation
- All hex literals use upper case letters after the x. - Fixed sime typos. - Documented some more functions.
- Added recent contributors to thanks list. - Linked PGP key for private mails. - Updated compiler list.
Update required all CHECK_THROWS_AS macros to pass the exception type without reference, because this is now done by Catch2.
README.md
Outdated
|
||
## Contact | ||
|
||
If you have questions regarding the library, I would like to invite you to [open an issue at Github](https://github.com/nlohmann/json/issues/new). Please describe your request, problem, or question as detailed as possible, and also mention the version of the library you are using as well as the version of your compiler and operating system. Opening an issue at Github allows other users and contributors to this library to collaborate. For instance, I have little experience with MSVC, and most issues in this regard have been solved by a growing community. If you have a look at the [closed issues](https://github.com/nlohmann/json/issues?q=is%3Aissue+is%3Aclosed), you will see that we react quite timely in most cases. | ||
|
||
Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me). | ||
Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me). For encrypted messages, please usse [this key](https://keybase.io/nlohmann/pgp_keys.asc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlohmann typo: usse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I shall fix this.
I noticed that you were cleaning up spaces around the |
@gregmarr This is due to Artistic Style which sometimes seems to interpret |
Oh, it's an auto formatter? |
Yes, see http://astyle.sourceforge.net. I am using it for some years now and have not found an equivalent Clang-format style. "My" style is implemented in the |
updated Catch(version 2.0.1 is slower than the 1.9.x version we use)Pull request checklist