Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overworked library toward 3.0.0 release #875

Merged
merged 6 commits into from
Dec 14, 2017
Merged

Overworked library toward 3.0.0 release #875

merged 6 commits into from
Dec 14, 2017

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Dec 13, 2017

  • fixed typos
  • updated README
  • updated Catch (version 2.0.1 is slower than the 1.9.x version we use)

Pull request checklist

- All hex literals use upper case letters after the x.
- Fixed sime typos.
- Documented some more functions.
- Added recent contributors to thanks list.
- Linked PGP key for private mails.
- Updated compiler list.
Update required all CHECK_THROWS_AS macros to pass the exception type without reference, because this is now done by Catch2.
README.md Outdated

## Contact

If you have questions regarding the library, I would like to invite you to [open an issue at Github](https://github.com/nlohmann/json/issues/new). Please describe your request, problem, or question as detailed as possible, and also mention the version of the library you are using as well as the version of your compiler and operating system. Opening an issue at Github allows other users and contributors to this library to collaborate. For instance, I have little experience with MSVC, and most issues in this regard have been solved by a growing community. If you have a look at the [closed issues](https://github.com/nlohmann/json/issues?q=is%3Aissue+is%3Aclosed), you will see that we react quite timely in most cases.

Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me).
Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me). For encrypted messages, please usse [this key](https://keybase.io/nlohmann/pgp_keys.asc).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlohmann typo: usse

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I shall fix this.

@gregmarr
Copy link
Contributor

I noticed that you were cleaning up spaces around the < and > in templates, but there are still a few left. 587, 592, 621, 885, 1000, 1614, 9909

@nlohmann
Copy link
Owner Author

@gregmarr This is due to Artistic Style which sometimes seems to interpret < and > as comparisons... :-(

@gregmarr
Copy link
Contributor

Oh, it's an auto formatter?

@nlohmann
Copy link
Owner Author

Yes, see http://astyle.sourceforge.net. I am using it for some years now and have not found an equivalent Clang-format style. "My" style is implemented in the make pretty target.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fb8482d on feature/spelling into f7ae143 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fb8482d on feature/spelling into f7ae143 on develop.

@nlohmann nlohmann merged commit 2e1b106 into develop Dec 14, 2017
@nlohmann nlohmann deleted the feature/spelling branch December 14, 2017 21:31
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9a70c60 on feature/spelling into f7ae143 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants