-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable metrics #70
Conversation
@nlopes What do you think about this? |
@CommanderStorm friendly ping? :) |
Ping about what? |
@potkae's question in the comment above. |
I am fine with the rationale. |
Okay then - would it be possible to merge the PR now? |
Not sure if anyone except @nlopes has write access to merge? Would need his review. |
Apologies, been away from this for some time. I'm going to try my very best to deal with some of these PRs, including this one. Bear with me. |
If you don't mind rebasing and resolving the conflicts, I can then take a look. Thanks! |
853b2c7
to
fc6ba8c
Compare
@nlopes Sorry for the delay, I was also away for a bit. It's now rebased & ready for review |
Thanks for doing that. Will try to review this week. |
@nlopes I'm not entirely sure how I would rebase this now with #74 merged. I think something like |
As far as I see the changes I've introduced regarding http version label was not released yet, so it should not be a breaking change to modify implementation to configure http version in a way you are proposing in this PR. |
71323e9
to
3bdd855
Compare
@nlopes friendly ping :) |
@nlopes I noticed some of your test runs were failing. |
…default and change only needed metrics. Makes breaking changes less likely
8f2b0cf
to
0d9b7c5
Compare
@nlopes rebased this again, ready for review & merging. |
This adds the possibility to rename metrics and the labels.
The solution is extendable for other possible metric specific configuration as well as adding new metrics.
Example usage to rename a default metric