Add ability to exclude paths and statuses from metrics #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely a clone of the Actix Logger middleware's `exclude` and `exclude_regex` APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the latest changes into #46 (thanks to @kppullin) and added an extra option to the builder to exclude an entire status code from the metrics. Useful to prevent any DoS vulnerability caused by too many 404s causing the metrics response to grow too large.
There is probably a better way to achieve that but I couldn't figure out how to get a list of paths from the service and this works for my use case.
Feel free to merge if it's useful or close otherwise.