Skip to content
This repository has been archived by the owner on Jul 13, 2019. It is now read-only.

Commit

Permalink
Prevent simultaneous execution of both diagnostics
Browse files Browse the repository at this point in the history
If both are run at the same time, they may interfere with each other
(as detailed in #51): the failure of one may block the other.

Instead, users have to explicitly start one or the other.
If they want to run both, they can just launch them sequentially.
  • Loading branch information
nmalkin committed Dec 23, 2018
1 parent 984156a commit 8bc4704
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion assets/diagnostics.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ <h1>Diagnostics</h1>
<p>Start a diagnostics test by clicking the appropriate button for your device.</p>
<p>Reminder: you'll need to be logged in to your Amazon/Google account.</p>
<p>
<button id="test" class="btn btn-primary">Run all diagnostics</button>
<button id="google" class="btn btn-primary">Run Google diagnostics</button>
<button id="amazon" class="btn btn-primary">Run Amazon diagnostics</button>
</p>
Expand Down
4 changes: 0 additions & 4 deletions src/chrome/pages/diagnostics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { Interaction } from '../../common/types';
import { initErrorHandling } from '../common/errors';

enum Tests {
all = 'all',
google = 'google',
amazon = 'amazon'
}
Expand Down Expand Up @@ -258,9 +257,6 @@ function runTests(testSuite: Tests) {
}

function setupDiagnostics() {
document.getElementById('test')!.onclick = () => {
runTests(Tests.all);
};
document.getElementById('google')!.onclick = () => {
runTests(Tests.google);
};
Expand Down

0 comments on commit 8bc4704

Please sign in to comment.