Adds PPG Column to Season-Long Records Tables (#92)

* commit on add-ppg-column-records * update version * ensure no 0 denominator Co-authored-by: OldNewsBlues <kovacsjc@gmail.com> Co-authored-by: Nicholas Melhado <n.melhado@gmail.com>
nmelhado · Jan 3, 2022 · 837def7 · 837def7
1 parent ef631ae
commit 837def7
Show file tree

Hide file tree

Showing 8 changed files with 27 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.2.11] - 2021-01-03
+
+### Added
+
+- PPG Records [#92](https://github.com/nmelhado/league-page/issues/92)
+    - Big thank you to [OldNewsBlues](https://github.com/OldNewsBlues) for implementing this
+
 ## [1.2.10] - 2022-01-03
 
 ### Fixed

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "league-page",
-  "version": "1.2.10",
+  "version": "1.2.11",
   "homepage": "https://github.com/nmelhado/league-page",
   "repository": {
     "type": "git",

diff --git a/src/lib/Records/AllTimeRecords.svelte b/src/lib/Records/AllTimeRecords.svelte
@@ -28,10 +28,11 @@
 
     for(const key in leagueRosterRecords) {
         const leagueRosterRecord = leagueRosterRecords[key];
+        const denominator = (leagueRosterRecord.wins + leagueRosterRecord.ties + leagueRosterRecord.losses) > 0 ? (leagueRosterRecord.wins + leagueRosterRecord.ties + leagueRosterRecord.losses) : 1;
         winPercentages.push({
             rosterID: key,
             manager: currentManagers[key],
-            percentage: round((leagueRosterRecord.wins + leagueRosterRecord.ties / 2) / (leagueRosterRecord.wins + leagueRosterRecord.ties + leagueRosterRecord.losses) * 100),
+            percentage: round((leagueRosterRecord.wins + leagueRosterRecord.ties / 2) / denominator * 100),
             wins: leagueRosterRecord.wins,
             ties: leagueRosterRecord.ties,
             losses: leagueRosterRecord.losses,
@@ -55,6 +56,7 @@
             manager: currentManagers[key],
             fptsFor: round(leagueRosterRecord.fptsFor),
             fptsAgainst: round(leagueRosterRecord.fptsAgainst),
+            fptsPerGame: round(leagueRosterRecord.fptsFor / denominator),
         })
     
         if(leagueRosterRecord.ties > 0) showTies = true;

diff --git a/src/lib/Records/PerSeasonRecords.svelte b/src/lib/Records/PerSeasonRecords.svelte
@@ -55,12 +55,14 @@
             }
 
 			const fpts = round(season.fpts);
+            const fptsPerGame = round(season.fptsPerGame);
 
             // add season-long scoring record
             yearsObj[season.year].seasonLongRecords.push({
                 manager: season.manager,
 				rosterID,
 				fpts,
+                fptsPerGame,
 				year: null,
 			})
 
@@ -93,6 +95,7 @@
                 manager: season.manager,
                 fptsFor: round(season.fpts),
                 fptsAgainst: round(season.fptsAgainst),
+                fptsPerGame: round(season.fptsPerGame),
             })
         }
     }

diff --git a/src/lib/Records/RecordsAndRankings.svelte b/src/lib/Records/RecordsAndRankings.svelte
@@ -432,7 +432,7 @@
     <DataTable class="recordTable">
         <Head>
             <Row>
-                <Cell class="header" colspan=4>{prefix} Season-long Scoring Records</Cell>
+                <Cell class="header" colspan=5>{prefix} Season-long Scoring Records</Cell>
             </Row>
             <Row>
                 <Cell class="header rank"></Cell>
@@ -441,6 +441,7 @@
                     <Cell class="header">Year</Cell>
                 {/if}
                 <Cell class="header">Total Points</Cell>
+                <Cell class="header">PPG</Cell>
             </Row>
         </Head>
         <Body>
@@ -457,6 +458,7 @@
                         <Cell>{mostSeasonLongPoint.year}</Cell>
                     {/if}
                     <Cell>{mostSeasonLongPoint.fpts}</Cell>
+                    <Cell>{mostSeasonLongPoint.fptsPerGame}</Cell>
                 </Row>
             {/each}
         </Body>
@@ -632,7 +634,7 @@
             <DataTable class="rankingTable">
                 <Head>
                     <Row>
-                        <Cell class="header" colspan=4>
+                        <Cell class="header" colspan=5>
                             {prefix} Fantasy Points Rankings
                         </Cell>
                     </Row>
@@ -641,6 +643,7 @@
                         <Cell class="header">Manager</Cell>
                         <Cell class="header">Points For</Cell>
                         <Cell class="header">Points Against</Cell>
+                        <Cell class="header">Points Per Game</Cell>
                     </Row>
                 </Head>
                 <Body>
@@ -655,6 +658,7 @@
                             </Cell>
                             <Cell>{fptsHistory.fptsFor}</Cell>
                             <Cell>{fptsHistory.fptsAgainst}</Cell>
+                            <Cell>{fptsHistory.fptsPerGame}</Cell>
                         </Row>
                     {/each}
                 </Body>

diff --git a/src/lib/utils/helperFunctions/leagueRecords.js b/src/lib/utils/helperFunctions/leagueRecords.js
@@ -6,6 +6,7 @@ import { getLeagueUsers } from "./leagueUsers"
 import { waitForAll } from './multiPromise';
 import { get } from 'svelte/store';
 import {records} from '$lib/stores';
+import { round } from './universalFunctions';
 
 export const getLeagueRecords = async (refresh = false) => {
 	if(get(records).seasonWeekRecords) {
@@ -99,6 +100,7 @@ export const getLeagueRecords = async (refresh = false) => {
 
 			const fpts = roster.settings.fpts + (roster.settings.fpts_decimal / 100);
 			const fptsAgainst = roster.settings.fpts_against + (roster.settings.fpts_against_decimal / 100);
+			const fptsPerGame = fpts / (roster.settings.wins + roster.settings.losses + roster.settings.ties);
 			const potentialPoints = roster.settings.ppts + (roster.settings.ppts_decimal / 100);
 
 			// add records to league roster record record
@@ -116,6 +118,7 @@ export const getLeagueRecords = async (refresh = false) => {
 				ties: roster.settings.ties,
 				fpts,
 				fptsAgainst,
+				fptsPerGame,
 				potentialPoints,
 				manager: originalManagers[rosterID],
 				year
@@ -126,6 +129,7 @@ export const getLeagueRecords = async (refresh = false) => {
 			mostSeasonLongPoints.push({
 				rosterID,
 				fpts,
+				fptsPerGame: round(fptsPerGame),
 				year,
 				manager: originalManagers[rosterID]
 			})

diff --git a/src/lib/version.js b/src/lib/version.js
@@ -5,4 +5,4 @@ available for your copy of League Page
 */
 
 // Keep in sync with package.json
-export const version = "1.2.10";
+export const version = "1.2.11";