Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to tracking rankings by manager #185

Merged
merged 22 commits into from
Jan 10, 2023
Merged

Converting to tracking rankings by manager #185

merged 22 commits into from
Jan 10, 2023

Conversation

nmelhado
Copy link
Owner

@nmelhado nmelhado commented Jan 8, 2023

This PR holds several key changes

  • Rankings are now tracked by manager (for all time records as well as in the manager page)
    • This increases the overall accuracy of the Records and Rankings page (as well as the manager pages)
  • It now uses the league specific avatar (if one exists)
  • The chart style has been updated to better accommodate more entries (horizontal bars instead of vertical)
  • Waivers have received a face lift and now look much cleaner and better
  • Commissioner badge added on the managers pages

Preview of changes below:

Old New
old waivers new waivers
old waivers tr new waivers tr
old records single new records - single
old records vs new records vs
old chart new chart

Due to the enormity of this change, there may be bugs. I have done my best to check the edge conditions, but the scope of this is large enough that I may have missed some

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
legends-league ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 3:56PM (UTC)

@mnewk41
Copy link

mnewk41 commented Jan 13, 2023

I implemented this update and I do not see the commissioner badge on the managers page. Also after syncing the update my page still says my manager page needs an update?

@nmelhado
Copy link
Owner Author

@mnewk41 You need to add managerIDs to your managers in leagueInfo in order to get rid of the message, get the full benefit of the update (most accurate badges), and to see the commissioner badge.

@tylereric24
Copy link

After implementing the update should I be using my sleeper manager ID for blog posts now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants