-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with -ftrivial-auto-var-init=zero #133
Labels
bug
Something isn't working
Comments
Please wait until the pending pull request is being resolved. |
I don't see how it could conflict with #132 though, is there some concern there? |
@z3ntu could you please send a pull request for this patch? It will help to move changes forward. |
z3ntu
pushed a commit
to z3ntu/android-tools
that referenced
this issue
Mar 20, 2024
As per upstream guidance [0] we should compile the sources with this flag in order to not hit issues with using uninitialized variables. [0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/1#message-01ebff378bb51f7815b6ed8b035a57fbce0418ab Fixes nmeum#133
anatol
pushed a commit
to z3ntu/android-tools
that referenced
this issue
Mar 20, 2024
As per upstream guidance [0] we should compile the sources with this flag in order to not hit issues with using uninitialized variables. [0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/1#message-01ebff378bb51f7815b6ed8b035a57fbce0418ab Fixes nmeum#133
z3ntu
pushed a commit
to z3ntu/android-tools
that referenced
this issue
Mar 20, 2024
As per upstream guidance [0] we should compile the sources with this flag in order to not hit issues with using uninitialized variables. [0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/1#message-01ebff378bb51f7815b6ed8b035a57fbce0418ab Fixes nmeum#133 Co-authored-by: munix9 <44939650+munix9@users.noreply.github.com>
z3ntu
pushed a commit
to z3ntu/android-tools
that referenced
this issue
Mar 20, 2024
As per upstream guidance [0] we should compile the sources with this flag in order to not hit issues with using uninitialized variables. [0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/1#message-01ebff378bb51f7815b6ed8b035a57fbce0418ab Fixes nmeum#133 Co-authored-by: munix9 <44939650+munix9@users.noreply.github.com>
anatol
pushed a commit
that referenced
this issue
Mar 20, 2024
As per upstream guidance [0] we should compile the sources with this flag in order to not hit issues with using uninitialized variables. [0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/1#message-01ebff378bb51f7815b6ed8b035a57fbce0418ab Fixes #133 Co-authored-by: munix9 <44939650+munix9@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to upstream[0] there are several cases of variables or struct members not being initialized, but since they're using
-ftrivial-auto-var-init=zero
to build the code, those will be zero-initialized by the compiler already.The CMake files should add this flag also to not hit bugs[1] due to uninitialized variables.
I assume we should be able to add these lines here https://github.com/nmeum/android-tools/blob/master/vendor/CMakeLists.txt#L18
Let me know if I should open a pull request with this or if you have other suggestions.
[0] https://android-review.googlesource.com/c/platform/system/core/+/2963911/comments/233c6468_46a055c5
[1] https://gitlab.archlinux.org/archlinux/packaging/packages/android-tools/-/issues/4
The text was updated successfully, but these errors were encountered: