Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused patch for libandroidfw #150

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

eli-schwartz
Copy link
Contributor

The patch is unused now that the submodule is unused. I was a couple minutes too slow amending the previous PR include this deletion.

The patch is unused now that the submodule is unused. I was a couple
minutes too slow amending the previous PR include this deletion.
And GitHub Actions provides two pythons in their images. One is a custom
framework, and the other is the homebrew python. They install the same
files and then brew cannot update itself.

Just wipe out the one not managed by a real package manager.

Solution borrowed from https://github.com/mesonbuild/meson
@Biswa96 Biswa96 merged commit 10e585c into nmeum:master Jun 18, 2024
14 checks passed
@anatol
Copy link
Collaborator

anatol commented Jun 18, 2024

Thank you for the github CI fix!

@eli-schwartz
Copy link
Contributor Author

It's a problem I've fought before. :) Github unfortunately does not consider it worthwhile to design their runners correctly such that brew install is able to update the files it installed...

@eli-schwartz eli-schwartz deleted the remove-libandroidfw branch June 18, 2024 03:52
@anatol
Copy link
Collaborator

anatol commented Jun 18, 2024

It's a problem I've fought before. :) Github unfortunately does not consider it worthwhile to design their runners correctly such that brew install is able to update the files it installed...

Interesting, what is their reasoning for doing such a controversial decision?

@eli-schwartz
Copy link
Contributor Author

https://github.com/orgs/Homebrew/discussions/3895#discussioncomment-4130560
actions/setup-python#577

I think it has more or less died the death of "no one is motivated to look at the issue". The primary way it manifests, anyway, is that whenever python is updated in homebrew then brew errors out, but most of the year brew doesn't try to touch the python installation, and so, doesn't notice it's broken. So by the time anyone gets around to looking at the problem, it's not a problem anymore? :D

And then the problem comes back again, regularly...

MackBambu added a commit to MackBambu/BambuStudio that referenced this pull request Jun 22, 2024
GITHUB:no

nmeum/android-tools#150

The formula built, but is not symlinked into /usr/local ;##[error]The �rew link step did not complete successfully; Could not symlink bin/2to3;Target /usr/local/bin/2to3;already exists. You may want to remove it:rm '/usr/local/bin/2to3'
MackBambu added a commit to MackBambu/BambuStudio that referenced this pull request Jun 22, 2024
GITHUB:no

nmeum/android-tools#150

The formula built, but is not symlinked into /usr/local ;##[error]The �rew link step did not complete successfully; Could not symlink bin/2to3;Target /usr/local/bin/2to3;already exists. You may want to remove it:rm '/usr/local/bin/2to3'
MackBambu added a commit to MackBambu/BambuStudio that referenced this pull request Jun 22, 2024
GITHUB:no

nmeum/android-tools#150

The formula built, but is not symlinked into /usr/local ;##[error]The �rew link step did not complete successfully; Could not symlink bin/2to3;Target /usr/local/bin/2to3;already exists. You may want to remove it:rm '/usr/local/bin/2to3'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants