Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Issue Fixing, Add missing Stats values(additions, deletions, total) to CommitResponse, Add .net5 Support #186

Merged
merged 21 commits into from
Feb 28, 2021

Conversation

MypowerHD
Copy link
Contributor

@MypowerHD MypowerHD commented Oct 27, 2020

Hello i have some Changes for you,
I was missing the Stats Values in the Commit Response, so i add them.

There was several Naming Issues, theyr fixed now, an issue with an Try Catch where you not able to get the stacktrace when it would throw.

Do Not:

try
{
    // Do stuff that might throw an exception
}
catch (GitLabException e)
{
    if (e.HttpStatusCode == System.Net.HttpStatusCode.Forbidden) //Filter out Forbidden StatusCode
        return false;
    else
        throw e; // This destroys the strack trace information!
}

Do:

try
{
     // Do stuff that might throw an exception
}
catch (GitLabException e)
{
    if (e.HttpStatusCode == System.Net.HttpStatusCode.Forbidden) //Filter out Forbidden StatusCode
        return false;
    else
        throw; //This preserves the StackTrace
}

Copy link
Collaborator

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by net5 release

@MypowerHD MypowerHD changed the title Some Issue Fixing, Add Missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support Some Issue Fixing, Add missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support Oct 27, 2020
@MypowerHD MypowerHD changed the title Some Issue Fixing, Add missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support Some Issue Fixing, Add missing Stats values(additions, deletions, total) to CommitResponse, Add .net5 Support Oct 27, 2020
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@MypowerHD MypowerHD requested a review from jetersen October 27, 2020 15:01
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@MypowerHD MypowerHD requested a review from jetersen November 23, 2020 19:33
@jetersen jetersen merged commit bbd0741 into nmklotas:master Feb 28, 2021
MindaugasLaganeckas pushed a commit to MindaugasLaganeckas/GitLabApiClient that referenced this pull request Mar 9, 2021
…al) to CommitResponse, Add .net5 Support (nmklotas#186)

Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants