-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Issue Fixing, Add missing Stats values(additions, deletions, total) to CommitResponse, Add .net5 Support #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do Not: try { // Do stuff that might throw an exception } catch (Exception e) { throw e; // This destroys the strack trace information! }
jetersen
requested changes
Oct 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by net5 release
jetersen
reviewed
Oct 27, 2020
MypowerHD
changed the title
Some Issue Fixing, Add Missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support
Some Issue Fixing, Add missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support
Oct 27, 2020
MypowerHD
changed the title
Some Issue Fixing, Add missing Stats Values(additions, deletions, total) to CommitResponse, Add .net5 Support
Some Issue Fixing, Add missing Stats values(additions, deletions, total) to CommitResponse, Add .net5 Support
Oct 27, 2020
jetersen
reviewed
Oct 27, 2020
jetersen
reviewed
Nov 12, 2020
jetersen
approved these changes
Feb 28, 2021
MindaugasLaganeckas
pushed a commit
to MindaugasLaganeckas/GitLabApiClient
that referenced
this pull request
Mar 9, 2021
…al) to CommitResponse, Add .net5 Support (nmklotas#186) Co-authored-by: Joseph Petersen <josephp90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello i have some Changes for you,
I was missing the Stats Values in the Commit Response, so i add them.
There was several Naming Issues, theyr fixed now, an issue with an Try Catch where you not able to get the stacktrace when it would throw.
Do Not:
Do: