Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project variables support #72

Merged

Conversation

tellespallabob
Copy link
Contributor

Project client provides support to retrieve/add/update/delete environment variables for a given project

@tellespallabob tellespallabob force-pushed the feature/CreateVariablesProject branch from 54a0a2f to 9443981 Compare October 1, 2019 08:53
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #72 into master will decrease coverage by 0.4%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   24.07%   23.67%   -0.41%     
==========================================
  Files         115      118       +3     
  Lines        1537     1563      +26     
  Branches      111      111              
==========================================
  Hits          370      370              
- Misses       1093     1119      +26     
  Partials       74       74
Impacted Files Coverage Δ
.../Variables/Request/UpdateProjectVariableRequest.cs 0% <0%> (ø)
.../Models/Variables/Request/CreateVariableRequest.cs 0% <0%> (ø)
...LabApiClient/Models/Variables/Response/Variable.cs 0% <0%> (ø)
src/GitLabApiClient/ProjectsClient.cs 11.9% <0%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f796d9...fd028dd. Read the comment docs.

@tellespallabob tellespallabob force-pushed the feature/CreateVariablesProject branch from 3165451 to 64cefb5 Compare October 1, 2019 09:39
@tellespallabob tellespallabob force-pushed the feature/CreateVariablesProject branch from 64cefb5 to bccaad6 Compare October 1, 2019 09:54
@nmklotas
Copy link
Owner

Hello,

Thanks for the pr, can you check why the formatting fails in the CI?

Copy link
Collaborator

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really hope we could rework this PR to align with #68

@jetersen
Copy link
Collaborator

https://github.com/nmklotas/GitLabApiClient/commit/fd028dd8e94a53b9bd3f55fa6f568531c668ebb3.patch
@tellespallabob
You might want to set up an email alias on your GitHub account 🥇
Or look into fixing your git user.email config 😅
to get proper credit for your commits 🏆
https://help.github.com/articles/adding-an-email-address-to-your-github-account/
https://help.github.com/articles/setting-your-commit-email-address-in-git
then to amend your commits: https://stackoverflow.com/a/3042512

@jetersen jetersen dismissed their stale review October 11, 2019 08:30

Regarding the work in #68 feel free to merge this one, I will rebase my work.

@jetersen jetersen merged commit 3d6844b into nmklotas:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants