Fix refresh creating an infinite timeout loop #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the date is more than a week away, then the refresh period would be set to
Infinity
. This gets passed to asetTimeout
, which fires immediately causing a refresh loop, which in my instance resulted in 100% cpu usage.It could also be the cause of #160
The code already does a true-y check on period before issuing the setTimeout, this patch also explicitly checks for Infinity to ensure that the timeout doesn't fire
Infinite timeouts are a bit of a js quirk that really don't behave as expected - https://github.com/denysdovhan/wtfjs#an-infinite-timeout