Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed casting warnings from strtoul on macOS, change port to uint16_t. #38

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Jul 7, 2023

No description provided.

@nmoinvaz nmoinvaz added the warnings fix Fixes to compiler warnings label Jul 7, 2023
@nmoinvaz nmoinvaz requested a review from sergio-nsk July 7, 2023 15:27
@nmoinvaz nmoinvaz enabled auto-merge (rebase) July 7, 2023 15:27
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #38 (fb31294) into master (224e42e) will not change coverage.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   56.13%   56.13%           
=======================================
  Files          53       53           
  Lines        4621     4621           
  Branches     1061     1060    -1     
=======================================
  Hits         2594     2594           
  Misses       1341     1341           
  Partials      686      686           
Flag Coverage Δ
macos 50.37% <90.00%> (ø)
ubuntu 53.16% <91.66%> (ø)
ubuntu_curl 52.85% <91.66%> (ø)
windows 55.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util.c 80.10% <91.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nmoinvaz nmoinvaz force-pushed the nathan/dev/port-casting branch from fb31294 to 470d869 Compare July 7, 2023 18:52
@nmoinvaz nmoinvaz merged commit e2bbc55 into master Jul 7, 2023
@nmoinvaz nmoinvaz deleted the nathan/dev/port-casting branch July 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warnings fix Fixes to compiler warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants