-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for libjavascriptcoregtk-6.0. #82
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 59.42% 59.14% -0.28%
==========================================
Files 53 54 +1
Lines 4725 4891 +166
Branches 1082 1114 +32
==========================================
+ Hits 2808 2893 +85
- Misses 1317 1368 +51
- Partials 600 630 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
63f16be
to
62b00ea
Compare
79a0392
to
5c355ac
Compare
01e61ef
to
8681af3
Compare
CMakeLists.txt
Outdated
endif() | ||
pkg_search_module(JSCore6GTK javascriptcoregtk-6.0) | ||
if(JSCore6GTK_FOUND) | ||
pkg_check_modules(GObject REQUIRED gobject-2.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I should try to dynamically load g_object_ref
in code.
I also wonder if I should do a check for webkit libraries being loaded and only allow it to load the version associated with the version of webkit that is loaded, but it seems like overkill. |
9753c13
to
654a63f
Compare
654a63f
to
7957f0d
Compare
Appears Apple might be using an older version of the JavaScriptCore API. Remove unused JSCore4GTK functions.
7957f0d
to
0a22a43
Compare
No description provided.