Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libjavascriptcoregtk-6.0. #82

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

nmoinvaz
Copy link
Owner

No description provided.

@nmoinvaz nmoinvaz added the dependencies Pull requests that update a dependency file label Dec 23, 2024
@nmoinvaz nmoinvaz requested a review from sergio-nsk December 23, 2024 23:58
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 136 lines in your changes missing coverage. Please review.

Project coverage is 59.14%. Comparing base (6444b36) to head (0a22a43).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
execute_jsc.c 53.73% 57 Missing and 36 partials ⚠️
execute_jscore.c 39.70% 21 Missing and 20 partials ⚠️
execute.c 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   59.42%   59.14%   -0.28%     
==========================================
  Files          53       54       +1     
  Lines        4725     4891     +166     
  Branches     1082     1114      +32     
==========================================
+ Hits         2808     2893      +85     
- Misses       1317     1368      +51     
- Partials      600      630      +30     
Flag Coverage Δ
macos 55.75% <39.13%> (+0.14%) ⬆️
ubuntu 55.21% <53.69%> (+0.89%) ⬆️
ubuntu_curl 56.92% <53.20%> (+0.65%) ⬆️
windows 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch 3 times, most recently from 63f16be to 62b00ea Compare December 24, 2024 00:18
@nmoinvaz nmoinvaz marked this pull request as draft December 24, 2024 00:23
@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch 6 times, most recently from 79a0392 to 5c355ac Compare December 24, 2024 21:19
@nmoinvaz nmoinvaz marked this pull request as ready for review December 24, 2024 21:22
@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch 2 times, most recently from 01e61ef to 8681af3 Compare December 24, 2024 21:31
CMakeLists.txt Outdated
endif()
pkg_search_module(JSCore6GTK javascriptcoregtk-6.0)
if(JSCore6GTK_FOUND)
pkg_check_modules(GObject REQUIRED gobject-2.0)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I should try to dynamically load g_object_ref in code.

@nmoinvaz
Copy link
Owner Author

I also wonder if I should do a check for webkit libraries being loaded and only allow it to load the version associated with the version of webkit that is loaded, but it seems like overkill.

@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch 4 times, most recently from 9753c13 to 654a63f Compare December 24, 2024 23:23
@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch from 654a63f to 7957f0d Compare December 25, 2024 00:08
Appears Apple might be using an older version of the JavaScriptCore API.
Remove unused JSCore4GTK functions.
@nmoinvaz nmoinvaz force-pushed the nathan/dev/libjscoregtk6 branch from 7957f0d to 0a22a43 Compare December 25, 2024 00:11
@nmoinvaz nmoinvaz merged commit c744b88 into master Dec 25, 2024
19 of 22 checks passed
@nmoinvaz nmoinvaz deleted the nathan/dev/libjscoregtk6 branch December 25, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants