Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jscore: fix JSCoreGTK version conflict w/ loaded one by user app #83

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

sergio-nsk
Copy link
Collaborator

No description provided.

@sergio-nsk sergio-nsk added the bug Something isn't working label Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 43.51852% with 61 lines in your changes missing coverage. Please review.

Project coverage is 59.41%. Comparing base (8b2f739) to head (ffd844a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
execute_jscore.c 43.51% 31 Missing and 30 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   59.36%   59.41%   +0.05%     
==========================================
  Files          53       53              
  Lines        4722     4724       +2     
  Branches     1082     1082              
==========================================
+ Hits         2803     2807       +4     
+ Misses       1318     1317       -1     
+ Partials      601      600       -1     
Flag Coverage Δ
macos 55.59% <38.20%> (+0.06%) ⬆️
ubuntu 54.30% <42.99%> (+0.09%) ⬆️
ubuntu_curl 56.25% <42.99%> (+0.09%) ⬆️
windows 56.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz
Copy link
Owner

nmoinvaz commented Dec 24, 2024

FYI, I have a plan to do side-by-side v4 and v6 that I'm working on. They have different function exports.

@nmoinvaz nmoinvaz merged commit 7c9d8c6 into master Dec 24, 2024
21 of 22 checks passed
@nmoinvaz nmoinvaz deleted the sergio-nsk/jscore/1 branch December 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants