-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce lockfiles #786
Introduce lockfiles #786
Conversation
…ding with github actions
…d open source license check
I've read through the articles given, I think it makes sense to use those flags. I will therefore approve the PR, though the problems that using these flags cause and which Timo mentioned in the daily should of course be addressed. |
How did we manage the versions of the dependencies of our dependencies before this? |
I'm worried about the bloat of having so many |
For clarification (I think I didn't mention that before): my main motivation for the lockfiles is the following advantage mentioned in the first linked blog post:
I noticed in the past, that the package restore takes quite some time and did a quick research on how to speed it up. |
840d32b
to
037951e
Compare
The pipelines are now passing. I'm not sure yet if renovate updates lockfiles. If not, there will be problems. But in that case, or in case of any other problem, I'd just revert the introduction of the lockfiles. |
Readiness checklist
This PR enables lock files, which seems to be a good thing according to blog articles like https://www.meziantou.net/faster-and-safer-nuget-restore-using-source-mapping-and-lock-files.htm or https://devblogs.microsoft.com/nuget/enable-repeatable-package-restores-using-a-lock-file/.