Unify error (#332)

* refactor: simplify error * test: update error message * chore: fix vulnerability
nmshd · Nov 18, 2024 · 42d9011 · 42d9011
1 parent 1e71a96
commit 42d9011
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/...rc/modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.ts b/...rc/modules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.ts
@@ -49,17 +49,9 @@ export class CreateAttributeRequestItemProcessor extends GenericRequestItemProce
             return ValidationResult.success();
         }
 
-        if (typeof recipient !== "undefined") {
-            return ValidationResult.error(
-                ConsumptionCoreErrors.requests.invalidRequestItem(
-                    "The owner of the provided RelationshipAttribute for the `attribute` property can only be the Sender's Address, the Recipient's Address or an empty string. The latter will default to the Recipient's Address."
-                )
-            );
-        }
-
         return ValidationResult.error(
             ConsumptionCoreErrors.requests.invalidRequestItem(
-                "The owner of the provided RelationshipAttribute for the `attribute` property can only be the Sender's Address or an empty string. The latter will default to the Recipient's Address."
+                "The owner of the provided RelationshipAttribute for the `attribute` property can only be the address of the sender, recipient or an empty string. The latter will default to the address of the recipient."
             )
         );
     }

diff --git a/...dules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.test.ts b/...dules/requests/itemProcessors/createAttribute/CreateAttributeRequestItemProcessor.test.ts
@@ -117,7 +117,7 @@ describe("CreateAttributeRequestItemProcessor", function () {
             await When.iCallCanCreateOutgoingRequestItemWith({ attribute: relationshipAttributeOfSomeoneElse });
             await Then.theResultShouldBeAnErrorWith({
                 message:
-                    "The owner of the provided RelationshipAttribute for the `attribute` property can only be the Sender's Address, the Recipient's Address or an empty string. The latter will default to the Recipient's Address."
+                    "The owner of the provided RelationshipAttribute for the `attribute` property can only be the address of the sender, recipient or an empty string. The latter will default to the address of the recipient."
             });
         });
 
@@ -129,7 +129,7 @@ describe("CreateAttributeRequestItemProcessor", function () {
             await When.iCallCanCreateOutgoingRequestItemWith({ attribute: relationshipAttributeOfSomeoneElse }, TestIdentity.UNDEFINED);
             await Then.theResultShouldBeAnErrorWith({
                 message:
-                    "The owner of the provided RelationshipAttribute for the `attribute` property can only be the Sender's Address or an empty string. The latter will default to the Recipient's Address."
+                    "The owner of the provided RelationshipAttribute for the `attribute` property can only be the address of the sender, recipient or an empty string. The latter will default to the address of the recipient."
             });
         });
     });