Versioning with GitHub releases #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoenig134
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
slavistan
reviewed
Aug 19, 2024
jkoenig134
requested review from
slavistan,
sebbi08,
Magnus-Kuhn,
britsta and
Milena-Czierlinski
|
@Magnus-Kuhn & @britsta make sure to read the description and update the titles and labels of your open PRs! |
|
@stnmtz FYI! |
Milena-Czierlinski
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Looks reasonable to me, but I wouldn't consider myself to be an expert in the .ci and .github stuff. @jkoenig134 Just in case you want to wait for a more in depth review on that. Otherwise, if anything should arise we can fix it agily. :D
|
Thanks @Milena-Czierlinski, lets be agile! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
We will now publish our runtime using GitHub Releases, this has multiple effects on the work with this repository:
as discussed IQL was moved to another repo again as it doesn't need to get published along with the runtime: https://github.com/nmshd/iql
we do not upgrade versions of libs anymore in this Repository, instead we do our work and then release if we want using tags (created by gh releases)
We have to label our pull requests now. Additionally we do not use Scopes for PR titles anymore
Feature/A cool new FeaturebecomesA cool new Featurewith the LabelFeature-> please keep in mind that the labels ci, chore, dependencies, refactor and test will not occur in the changelog, if you want your feature to be included use another one.