Update ThirdPartyRelationshipAttribute nomenclature

[Milena-Czierlinski]

Readiness checklist

• I added/updated tests.
• I ensured that the PR title is good enough for the changelog.
• I labeled the PR.

[codecov]

Codecov Report

Attention: Patch coverage is 88.38174% with 28 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...nsumption/src/consumption/ConsumptionCoreErrors.ts	53.33%	7 Missing ⚠️
packages/runtime/src/events/EventProxy.ts	50.00%	6 Missing ⚠️
...ion/src/modules/attributes/AttributesController.ts	69.23%	4 Missing ⚠️
...ationshipAttributeDeletedByPeerNotificationItem.ts	85.18%	4 Missing ⚠️
...n/ThirdPartyRelationshipAttributeSucceededEvent.ts	80.00%	2 Missing ⚠️
...kages/runtime/src/useCases/common/RuntimeErrors.ts	33.33%	2 Missing ⚠️
...ion/src/modules/attributes/local/LocalAttribute.ts	92.85%	1 Missing ⚠️
...AttributeDeletedByPeerNotificationItemProcessor.ts	90.90%	1 Missing ⚠️
...eteThirdPartyRelationshipAttributeAndNotifyPeer.ts	94.73%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...nsumption/src/consumption/ConsumptionController.ts	96.73% <100.00%> (ø)
...irdPartyRelationshipAttributeDeletedByPeerEvent.ts	100.00% <100.00%> (ø)
...s/ThirdPartyRelationshipAttributeSucceededEvent.ts	100.00% <100.00%> (ø)
...consumption/src/modules/attributes/events/index.ts	100.00% <100.00%> (ø)
...ges/consumption/src/modules/notifications/index.ts	100.00% <100.00%> (ø)
...readAttribute/ReadAttributeRequestItemProcessor.ts	90.72% <100.00%> (-0.42%)	⬇️
packages/content/src/notifications/items/index.ts	100.00% <100.00%> (ø)
...rtyOwnedRelationshipAttributeDeletedByPeerEvent.ts	100.00% <100.00%> (ø)
...irdPartyRelationshipAttributeDeletedByPeerEvent.ts	100.00% <100.00%> (ø)
packages/runtime/src/events/consumption/index.ts	100.00% <100.00%> (ø)
... and 12 more

[jkoenig134]

Do we really need to introduce all these breaking changes now?

[Milena-Czierlinski]

@jkoenig134 Should we also keep a deprecated function deleteThirdPartyOwnedRelationshipAttributeAndNotifyPeer in addition to the new function deleteThirdPartyRelationshipAttributeAndNotifyPeer in the AttributesFacade for backwards compatibility?

[jkoenig134]

If one calls the other one, why not :)