Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create Relationship to deleted creator of RelationshipTemplate #361

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Dec 10, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

It is now possible to test in the Transport library that a Relationship cannot be created after the RelationshipTemplate has been loaded if the creator of the RelationshipTemplate has deleted its Identity in the meantime.

@britsta britsta added wip Work in Progress (blocks mergify from auto update the branch) test This pull request contains only new or changed tests labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@britsta britsta removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 10, 2024
@britsta britsta marked this pull request as ready for review December 10, 2024 12:31
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britsta britsta merged commit 85bba39 into main Dec 10, 2024
20 checks passed
@britsta britsta deleted the test/cannot-create-relationship-to-deleted-creator-of-relationshiptemplate branch December 10, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This pull request contains only new or changed tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants