Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestConfig is skipped if false is configured as value #381

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

Milena-Czierlinski
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski commented Jan 7, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Also, owner is removed from ProposeAttributeRequestItemConfig since it can only be the recipient anyway.

There remain problems with the owner of a CreateAttributeRequestItem and ReadAttributeRequestItem, because an empty strings needs to be converted to the address of the recipient. However, I'll tackle these issues in a separate PR.

@Milena-Czierlinski Milena-Czierlinski added the bug Something isn't working label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/runtime/src/modules/DeciderModule.ts 93.51% <100.00%> (-0.50%) ⬇️
...ckages/runtime/src/modules/decide/RequestConfig.ts 100.00% <ø> (ø)

@Milena-Czierlinski Milena-Czierlinski added the wip Work in Progress (blocks mergify from auto update the branch) label Jan 7, 2025
@Milena-Czierlinski Milena-Czierlinski removed the wip Work in Progress (blocks mergify from auto update the branch) label Jan 8, 2025
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review January 8, 2025 08:51
@Milena-Czierlinski Milena-Czierlinski merged commit b25d1cc into main Jan 8, 2025
19 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the requestconfig-is-skipped-for-false branch January 8, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants