Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline debug logging for SynchronizedCollection data inconsistencies #382

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Jan 7, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@sebbi08 sebbi08 added the chore Some routine work like updating dependencies label Jan 7, 2025
@sebbi08 sebbi08 requested a review from jkoenig134 January 7, 2025 10:57
@jkoenig134
Copy link
Member

@sebbi08 please re-check the PR title, you checked the I ensured that the PR title is good enough for the changelog. checkbox, but it isn't.

Please treat these checkboxes as actual task that need to be done before requesting any reviews.

@sebbi08 sebbi08 changed the title chore: add old and new doc to log when data inconsistency is detected Add old and new doc to log when data inconsistency is detected Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ansport/src/modules/sync/SynchronizedCollection.ts 28.57% 5 Missing ⚠️
Files with missing lines Coverage Δ
...ansport/src/modules/sync/SynchronizedCollection.ts 35.24% <28.57%> (-0.80%) ⬇️

@jkoenig134 jkoenig134 changed the title Add old and new doc to log when data inconsistency is detected Improve pipeline debug logging for SynchronizedCollection data inconsistencies Jan 7, 2025
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure to have a correct commit message (as you only have one commit this will not be automatic)

@sebbi08 sebbi08 merged commit 1e8f177 into main Jan 8, 2025
18 checks passed
@sebbi08 sebbi08 deleted the feature/add_objects_to_inconsistency_log branch January 8, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Some routine work like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants