Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runtime errors for IdentityMetadata use cases #383

Merged

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Jan 8, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

It should not be possible to create IdentityMetadata for Identities whose address is not known. An address is known if it is your own address or the address of a peer of a Relationship.

In addition, a special error for records that could not be found was introduced for IdentityMetadata. This was necessary because IdentityMetadata is usually accessed by an Integrator of a Connector via its combination of reference and key and not via its id.

@britsta britsta added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...kages/runtime/src/useCases/common/RuntimeErrors.ts 83.22% <100.00%> (+0.76%) ⬆️
...umption/identityMetadata/DeleteIdentityMetadata.ts 100.00% <100.00%> (+4.87%) ⬆️
...onsumption/identityMetadata/GetIdentityMetadata.ts 100.00% <100.00%> (ø)
...umption/identityMetadata/UpsertIdentityMetadata.ts 100.00% <100.00%> (ø)

@britsta britsta removed the wip Work in Progress (blocks mergify from auto update the branch) label Jan 8, 2025
@britsta britsta marked this pull request as ready for review January 8, 2025 11:29
@britsta britsta requested a review from jkoenig134 January 8, 2025 11:29
@britsta britsta enabled auto-merge (squash) January 8, 2025 11:29
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britsta britsta merged commit 3db301c into main Jan 9, 2025
18 checks passed
@britsta britsta deleted the feature/add-errors-for-crud-operations-of-identitymetadata branch January 9, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants