-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict character sets for attribute values #397
Draft
Magnus-Kuhn
wants to merge
41
commits into
main
Choose a base branch
from
restrict-character-sets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnus-Kuhn
added
breaking-change
A breaking change
enhancement
New feature or request
wip
Work in Progress (blocks mergify from auto update the branch)
labels
Jan 24, 2025
Magnus-Kuhn
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Jan 30, 2025
Magnus-Kuhn
requested review from
sebbi08,
jkoenig134,
stnmtz,
britsta and
Milena-Czierlinski
January 30, 2025 10:24
@stnmtz, could you have a look at the datatype assignments to the attribute types? |
@Magnus-Kuhn as this is a breaking change please
until we are ready to merge. |
Magnus-Kuhn
added
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Jan 30, 2025
britsta
reviewed
Jan 31, 2025
Magnus-Kuhn
commented
Feb 3, 2025
packages/content/src/attributes/types/proprietary/ProprietaryJSON.ts
Outdated
Show resolved
Hide resolved
Milena-Czierlinski
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires additional approval of @stnmtz once we want to merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
A breaking change
enhancement
New feature or request
wip
Work in Progress (blocks mergify from auto update the branch)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Notes
When adding documentation, note that only NFC normalized strings are considered valid.