Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict character sets for attribute values #397

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

Magnus-Kuhn
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn commented Jan 24, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Notes

When adding documentation, note that only NFC normalized strings are considered valid.

@Magnus-Kuhn Magnus-Kuhn added breaking-change A breaking change enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch) labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review January 30, 2025 10:23
@Magnus-Kuhn Magnus-Kuhn removed the wip Work in Progress (blocks mergify from auto update the branch) label Jan 30, 2025
@Magnus-Kuhn
Copy link
Contributor Author

@stnmtz, could you have a look at the datatype assignments to the attribute types?

@jkoenig134
Copy link
Member

@Magnus-Kuhn as this is a breaking change please

  1. put it back to draft
  2. re-add wip

until we are ready to merge.

@Magnus-Kuhn Magnus-Kuhn marked this pull request as draft January 30, 2025 10:39
@Magnus-Kuhn Magnus-Kuhn added the wip Work in Progress (blocks mergify from auto update the branch) label Jan 30, 2025
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires additional approval of @stnmtz once we want to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants