Fix global linkages #383
Merged
Fix global linkages #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
First of all, thank you for your library, it's awesome and useful.
But here's a tiny fix I dare to propose: as soon some of the headers contain definitions without
staticspecified, could you add it to them?Currenlty those definitions have global linkage, which means that in certain cases someone is likely to get "multiple definitions" error, I can provide you a MCVE of that here or in a separate issue if you like.
The fix is small and should not affect performance, tests pass fine.
@yurymalkov , what'd you say?