-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve wheel build failure on x86_64 architecture due to -march=native flag #455
base: develop
Are you sure you want to change the base?
Conversation
Merge 0.7.0 into master
Hm. |
We can try to understand if the compiler is clang with something like import sys
import platform
import subprocess
import re
def is_clang_compiler():
try:
# Run the compiler version command
result = subprocess.run(['cc', '--version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
output = result.stdout.lower()
# Check if the output contains the word 'clang'
return 'clang' in output
except FileNotFoundError:
# If the 'cc' command is not found, it's not Clang
return False |
Can you double check that your compiler is set up properly? I've added macos to the CI with x64 and the tests are passing. |
My Mac is 2019 version. >>> result = subprocess.run(['cc', '--version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
>>> output = result.stdout.lower()
>>> output
'apple clang version 14.0.3 (clang-1403.0.22.14.1)\ntarget: x86_64-apple-darwin22.4.0\nthread model: posix\ninstalleddir: /applications/xcode.app/contents/developer/toolchains/xcodedefault.xctoolchain/usr/bin\n' |
@XiChenn Can you check if the other change fixes your problem by running |
fwiw, @yurymalkov I was having the same issue as @XiChenn (Mac x86_64 architecture) and installing via #461's head worked for me. |
The hnswlib wheel build failed on my MacOS (x86_64 architecture) when I run
pip install hnswlib
.Similar to the solution of the previous merged PR, by removing the building flag resolves the issue.