Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Increase timeout to 3m #945

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Dec 13, 2021

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What this PR does / why we need it:
Looks like golangci-lint github actions is taking more time than
expected as reported at other projects [1]. This change increase the
timeout to 3m.

[1] golangci/golangci-lint-action#297

Special notes for your reviewer:

Release note:

NONE

Looks like golangci-lint github actions is taking more time than
expected as reported at other projects [1]. This change increase the
timeout to 3m.

[1] golangci/golangci-lint-action#297

Signed-off-by: Quique Llorente <ellorent@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Dec 13, 2021
@qinqon
Copy link
Member Author

qinqon commented Dec 13, 2021

/override pull-kubernetes-nmstate-docs
/override pull-kubernetes-nmstate-e2e-handler-k8s
/override pull-kubernetes-nmstate-e2e-handler-k8s-future
/override pull-kubernetes-nmstate-e2e-operator-k8s
/override pull-kubernetes-nmstate-unit-test

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-kubernetes-nmstate-docs, pull-kubernetes-nmstate-e2e-handler-k8s, pull-kubernetes-nmstate-e2e-handler-k8s-future, pull-kubernetes-nmstate-e2e-operator-k8s, pull-kubernetes-nmstate-unit-test

In response to this:

/override pull-kubernetes-nmstate-docs
/override pull-kubernetes-nmstate-e2e-handler-k8s
/override pull-kubernetes-nmstate-e2e-handler-k8s-future
/override pull-kubernetes-nmstate-e2e-operator-k8s
/override pull-kubernetes-nmstate-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrazdil
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@kubevirt-bot kubevirt-bot merged commit 3481e67 into nmstate:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants