Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zmq-load #17

Closed
wants to merge 1 commit into from
Closed

Remove zmq-load #17

wants to merge 1 commit into from

Conversation

conao3
Copy link

@conao3 conao3 commented Mar 18, 2020

Hi!

This package will be prompted during package-install for this top-level zmq-load.
This requires me to respond when installing more than 100 packages, making batch installation difficult.

@nnicandro
Copy link
Owner

Thanks, but this behavior is actually mentioned in the README (https://github.com/dzop/emacs-zmq#installation). Users already expect not to have to call zmq-load manually. I will have to think more about what to do. Any suggestions?

Also, the tests are failing. To fix them you can add a zmq-load call to zmq-tests.el.

@conao3
Copy link
Author

conao3 commented Mar 19, 2020

How about put the binaries in a directory like bin and include them in MELPA packaging?

@ChauhanT
Copy link

Or perhaps check the user's OS-type and automatically download and install the right binary?

@nnicandro
Copy link
Owner

One solution would be to let bind noninteractive to t around the package installs so that zmq will attempt to automatically download the binaries. I would prefer to ask for the user's permission if it is an interactive session before trying to download anything.

nnicandro added a commit that referenced this pull request Jun 29, 2024
Do so instead of a call to `zmq-load` at top-level.

closes #17

* zmq.el: Replace top-level `zmq-load` call with aliasing of core ZMQ
functions to `zmq-load`, but only if the core functionality hasn't
been loaded yet.  Loading of the core functionality will overwrite
these aliased definitions with the proper ones.
nnicandro added a commit that referenced this pull request Jun 29, 2024
Do so instead of a call to `zmq-load` at top-level.

closes #17

* zmq.el: Replace top-level `zmq-load` call with aliasing of core ZMQ
functions to `zmq-load`, but only if the core functionality hasn't
been loaded yet.  Loading of the core functionality will overwrite
these aliased definitions with the proper ones.
nnicandro added a commit that referenced this pull request Jul 15, 2024
Do so instead of a call to `zmq-load` at top-level.

closes #17

* zmq.el: Replace top-level `zmq-load` call with aliasing of core ZMQ
functions to `zmq-load`, but only if the core functionality hasn't
been loaded yet.  Loading of the core functionality will overwrite
these aliased definitions with the proper ones.
@nnicandro nnicandro closed this in 62b6b00 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants