Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeClean] dependency to ml-agent #435

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[CodeClean] dependency to ml-agent #435

merged 2 commits into from
Jan 9, 2024

Conversation

jaeyun-jung
Copy link
Collaborator

Prepare deleting ml-agent from api repo, set dependency to ml-agent and remove unnecessary line.

@jaeyun-jung
[CodeClean] fix indent and codestyle
a5b53db 
Code clean, fix indent and code style.

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Jan 4, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #435. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 4, 2024

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/435-202401041951000.42183995246887-0a1dc28ca50f152452e229eb893949e5d5da6b78/.

taos-ci
taos-ci approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung
[CodeClean] dependency to ml-agent
a6ac02b 
Prepare deleting ml-agent from api repo, set dependency to ml-agent and remove unnecessary line.

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
taos-ci
taos-ci approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeyun-jung jaeyun-jung merged commit a66f081 into nnstreamer:main Jan 9, 2024
29 checks passed
@jaeyun-jung jaeyun-jung deleted the prepare-del-mlagent branch January 9, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaeyun-jung @taos-ci @anyj0527