Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to external resouce download method #437

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Change to external resouce download method #437

merged 1 commit into from
Jan 10, 2024

Conversation

gichan-jang
Copy link
Member

Downloading a specific directory of git using svn is no longer supported.
Change the method of downloading from svn to git.
refer: https://github.blog/2023-01-20-sunsetting-subversion-support

Signed-off-by: gichan2-jang gichan2.jang@samsung.com

@gichan-jang
Change to external resouce download method
62b8c07 
Downloading a specific directory of git using svn is no longer supported.
Change the method of downloading from svn to git.
refer: https://github.blog/2023-01-20-sunsetting-subversion-support

Signed-off-by: gichan2-jang <gichan2.jang@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Jan 10, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #437. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 10, 2024

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/437-202401101716410.56722903251648-62b8c07d41b5a9e98005d4240f5db89991f9f2d5/.

anyj0527
anyj0527 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@jaeyun-jung
Copy link
Collaborator

This PR does not affect tizen build. To prevent build error for android lib, I merge this now.

@jaeyun-jung jaeyun-jung merged commit 18fab9b into nnstreamer:main Jan 10, 2024
24 of 29 checks passed
@gichan-jang gichan-jang deleted the fix/android branch February 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gichan-jang @taos-ci @jaeyun-jung @anyj0527