Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-Api] remove space of models #448

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jaeyun-jung
Copy link
Collaborator

To prevent not-found error, remove space of model path. Also check file existence when validating model files.

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 22, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #448. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
To prevent not-found error, remove space of model path.
Also check file existence when validating model files.

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✔

Copy link
Collaborator

@again4you again4you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@again4you again4you merged commit 5a204fd into nnstreamer:main Jan 25, 2024
29 checks passed
@jaeyun-jung jaeyun-jung deleted the capi-modelpath-strip branch January 26, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants