Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLAgent: Remove ml-agent from this repository @open sesame 03/07 18:49 #455

Merged
merged 1 commit into from
Mar 7, 2024
Merged

MLAgent: Remove ml-agent from this repository @open sesame 03/07 18:49 #455

merged 1 commit into from
Mar 7, 2024

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Feb 5, 2024 •
edited
Loading

This patch removes ml-agent and modifies the build scripts and Tizen RPM spec file as well.
Note that some of the test cases are occasionally failed for no reason.

Before merging it, nnstreamer/deviceMLOps.MLAgent#22 is required to be merged and https://github.com/nnstreamer/deviceMLOps.MLAgent should be imported to Tizen and deployed.

Signed-off-by: Wook Song wook16.song@samsung.com

v2

v3

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 5, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #455. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 5, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402051759050.67226505279541-24695f6e119e50dda41c88727206ae91a8f20334/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 6, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402061339530.71042895317078-3c8573efb4527232996e8894a589473d76526028/.

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Feb 8, 2024
Merged
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 13, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402131406200.83431911468506-2b4e5f661e839a6c772e6f57c9977639b4bd11dc/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 13, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402131517240.82870197296143-b460e625e45795ba83d23dc4bdfab61f0cb2ee35/.

@wooksong wooksong force-pushed the remove-ml-agent branch 2 times, most recently from b9800be to 092d9af Compare February 19, 2024 03:02
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 19, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402191202280.31410002708435-092d9af8f4b8bf543683e61144a9c4d8d8ebed82/.

@wooksong wooksong changed the title MLAgent: Remove ml-agent from this repository MLAgent: Remove ml-agent from this repository @open sesame 02/19 12:30 Feb 19, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Feb 19, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402191249550.55942010879517-f455501ecd3d5ce41e3dc3c5b1351e1caba4d38b/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 22, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402221337280.31092309951782-431c58009b0e292dcadf7ae6c4e4718e189946b5/.

@taos-ci
Copy link
Collaborator

taos-ci commented Feb 22, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202402221421360.061631917953491-af56d62e889146b0b69eb32a49b9220aeedccc65/.

@wooksong wooksong mentioned this pull request Feb 26, 2024
Merged
@wooksong wooksong changed the title MLAgent: Remove ml-agent from this repository @open sesame 02/19 12:30 MLAgent: Remove ml-agent from this repository @open sesame 03/06 10:15 Mar 6, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Mar 6, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202403061016420.41144990921021-af56d62e889146b0b69eb32a49b9220aeedccc65/.

@wooksong
MLAgent: Remove ml-agent from this repository
842f07e 
This patch removes ml-agent and modifies the build scripts and Tizen RPM
spec file as well.

Signed-off-by: Wook Song <wook16.song@samsung.com>
@taos-ci
Copy link
Collaborator

taos-ci commented Mar 6, 2024

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/455-202403061516220.85479807853699-842f07edac3fed7be4f4021ccabc902645b0cfce/.

gichan-jang
gichan-jang approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/meson.build
@@ -20,24 +20,6 @@ unittest_common_dep = declare_dependency(
include_directories: nns_capi_include,
)

if get_option('enable-ml-service')
subdir('mock')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove mock dir and files.

packaging/machine-learning-api.spec
@@ -561,8 +509,6 @@ install -m 0755 packaging/run-unittest.sh %{buildroot}%{_bindir}/tizen-unittests
%files -n capi-machine-learning-unittests
%manifest capi-machine-learning.manifest
%{_bindir}/unittest-ml
%{_libdir}/libml-agent-test.a
%{_libdir}/libml-agent-test.so*
%{_libdir}/libunittest_mock.so*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this line.

@jaeyun-jung jaeyun-jung changed the title MLAgent: Remove ml-agent from this repository @open sesame 03/06 10:15 MLAgent: Remove ml-agent from this repository @open sesame 03/07 18:49 Mar 7, 2024
taos-ci
taos-ci approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooksong, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit 30318a8 into nnstreamer:main Mar 7, 2024
29 checks passed
@wooksong wooksong deleted the remove-ml-agent branch March 8, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@gichan-jang gichan-jang gichan-jang approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wooksong @taos-ci @myungjoo @jaeyun-jung @gichan-jang