App/Service: Revise the getIpAddress method #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooksong
requested review from
myungjoo,
again4you,
jaeyun-jung,
songgot,
gichan-jang,
anyj0527,
niley7464,
yeonykim2 and
a team
as code owners
niley7464
approved these changes
May 30, 2024
niley7464
reviewed
May 30, 2024
ml_inference_offloading/src/main/java/ai/nnstreamer/ml/inference/offloading/App.kt
Outdated
Show resolved
Hide resolved
This patch introduces a property to check that the app is running on the Android Emulator. Signed-off-by: Wook Song <wook16.song@samsung.com>
Several properties in the Application class are dynamically bound after the application launches, which means accessing those properties before bound incurs NPE. To avoid such unintended NPE, this patch introduces the App singleton class holding those properties like applicationContext. Signed-off-by: Wook Song <wook16.song@samsung.com>
This patch revises the getIpAddress method to return the proper localhost address corresponding to the emulator or the real target. Moreover, the platform type variables are eliminated. Signed-off-by: Wook Song <wook16.song@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch revises the getIpAddress method to return the proper localhost address corresponding to the emulator or the real target. Moreover, the platform-type variables are eliminated.
Signed-off-by: Wook Song wook16.song@samsung.com