[Tensor] Fix improper vector initialization in Tensor::split function #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
EunjuYang,
dkjung and
haehun
as code owners
skykongkong8
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
While this suggestion itself sounds good, it seems this won't fix #2900..
djeong20
force-pushed
the
hotfix/split/test
branch
from
0ea4b37 to
a7a8b9c
Compare
djeong20
force-pushed
the
hotfix/split/test
branch
5 times, most recently
from
0b0144f to
c2b64f3
Compare
This pull request addresses the issue of improper vector initialization that leads to an error in the Tensor::split function. Previously, the vector was reserved but accessed directly without inserting any elements. Reserving memory only allocates space internally, leaving the vector uninitialized. **Changes proposed in this PR:** - Initialize the vector using the constructor that takes count copies of elements. - Properly initialize tensors when they are added to a vector of tensors. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
djeong20
force-pushed
the
hotfix/split/test
branch
from
c2b64f3 to
5d5e89e
Compare
djeong20
changed the title
|
Thanks for your hard work to fix it ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue of improper vector initialization that leads to an error in the
Tensor::splitfunction. Previously, the vector was reserved but accessed directly without inserting any elements. Reserving memory only allocates space internally, leaving the vector uninitialized.Changes proposed in this PR:
Self-evaluation: