Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for breaking compilers #82

Closed
wants to merge 1 commit into from
Closed

Conversation

devotox
Copy link

@devotox devotox commented Nov 20, 2017

it just needs a semicolon at the end

@tjvr
Copy link
Collaborator

tjvr commented Nov 20, 2017

Hello, please can you explain this change? Thanks! :)

@devotox
Copy link
Author

devotox commented Nov 20, 2017 via email

@tjvr
Copy link
Collaborator

tjvr commented Nov 20, 2017

How are you passing the files to UglifyJS? Are you concatenating them onto its stdin, or listing them as arguments on the command-line?

@devotox
Copy link
Author

devotox commented Nov 20, 2017

Ember JS is automatically passing them in. i do not actually know the internals but what i do see is that it takes this function plus anything next and seems to add it as one when the semicolon was not there

@nathan
Copy link
Collaborator

nathan commented Nov 20, 2017

@devotox in addition to this issue, you should probably report this as a bug in whatever tool you are using since it's turning valid JS into invalid JS

(Ah, the good old days of twbs/bootstrap#3057 :P)

@devotox
Copy link
Author

devotox commented Nov 20, 2017

@nathan gottaaaa love those days loool

@tjvr tjvr closed this in 8c3e622 Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants