Update Nvidia sai.profile SKU files to use common file #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaOrMlnx
force-pushed
the
sai_profile_enhancements
branch
from
ad4e5f9
to
e4388c7
Compare
noaOrMlnx
changed the title
noaOrMlnx
force-pushed
the
sai_profile_enhancements
branch
from
e4388c7
to
2dd6433
Compare
nazariig
suggested changes
Jan 24, 2024
nazariig
suggested changes
Jan 24, 2024
| @@ -0,0 +1,3 @@ | |||
| SAI_DUMP_STORE_PATH=/var/log/mellanox/sdk-dumps | |||
| SAI_DUMP_STORE_AMOUNT=10 | |||
| SAI_DUMP_MFT_CFG_PATH=/etc/mft/fwtrace_cfg | |||
There was a problem hiding this comment.
@noaOrMlnx do we need the same for syncd RPC docker? What about VS docker?
noaOrMlnx
force-pushed
the
sai_profile_enhancements
branch
2 times, most recently
from
b6cea3b
to
a6806af
Compare
nazariig
reviewed
Feb 7, 2024
nazariig
approved these changes
Feb 8, 2024
noaOrMlnx
force-pushed
the
sai_profile_enhancements
branch
from
a6806af
to
58228ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new common sai.profile,
Update Nvidia/Mellanox sai.profile of all SKUs to remove common parameters.
Why I did it
To have the ability to add common parameters to only 1 file instead of all SKUs.