Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing xesmf remap test #119

Merged
merged 8 commits into from
Dec 20, 2022
Merged

Fix failing xesmf remap test #119

merged 8 commits into from
Dec 20, 2022

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Dec 19, 2022 •
edited
Loading

Resolves #118 and addresses xarray .drop() -> .drop_vars() warning.

  • Constrain dev conda env so xesmf and the test work currently
  • Add message so that failure of .remap_xesmf due to xesmf import failure isn't completely silent

@zmoon zmoon changed the base branch from stable to develop December 19, 2022 17:39
@zmoon zmoon marked this pull request as ready for review December 19, 2022 18:20
@zmoon
cleanup
797bc65
@zmoon
xesmf v0.7 is on cf
71606f7 
so these contraints are no longer necessary
@zmoon zmoon merged commit a2ff29a into noaa-oar-arl:develop Dec 20, 2022
@zmoon zmoon deleted the drop branch December 20, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remap test failing
1 participant
@zmoon