Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stratify usage for v0.3 and add tests #135

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented May 25, 2023

Resolves #134

  • Cleaned up the da output a bit (adding name from input da, eliminating extra "coords")
  • Fixed xarray ds accessor method

cc: @colin-harkins

zmoon added 7 commits May 25, 2023 10:00
works with v0.2
seems to work same in v0.2
ones with z dim wouldn't be though, so don't copy those

also don't need to copy dim DataArrays, this was causing those
to be set as coords in the result

if they are dim coords, copying the coord var will get the data
we need/want
@zmoon zmoon requested a review from bbakernoaa May 25, 2023 17:33
@zmoon zmoon merged commit e7cf636 into noaa-oar-arl:develop Jun 9, 2023
@zmoon zmoon deleted the strat branch June 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant