-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine spatial data and xarray point obs #97
Conversation
This comment has been minimized.
This comment has been minimized.
@bbakernoaa when you get a chance could you let me know what remains to be done here? |
I don't think anything else needs to be done here. We have been using this in the MELODIES-MONET project so I think it should be ready to merge. |
@bbakernoaa in the new functions the docstring parameters listed don't match the signature in some cases, and for some I am not sure how to fix. Would you be able to have a quick go at that? |
I'll try to take a look at it soon |
@bbakernoaa I made some edits. I am a little confused though: for |
@zmoon lets talk about this tomorrow as I'm a little confused |
@rschwant could you point to me how/where in MM you are using this? |
and a fix or two
these aren't ready but aren't used in MM
Also made additional docstring edits
xref: NOAA-CSL/MELODIES-MONET#115
combine_da_to_da
utility function.monet
combine_da
methods.monet
accessor methods