Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/_camx_mm consistent with _wrfchem_mm #197

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

blychs
Copy link
Contributor

@blychs blychs commented Oct 2, 2024

This makes the camx_mm reader consistent with wrfchem_mm by incorporating "dz_m" instad of "layer_height_agl"
We had talked at the time of adapting it once the new wrfchem_mm reader was accepted.

Cheers
Pablo

Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blychs I'm a bit confused.

Does your layer_height_agl correspond to alt_agl_m_mid in the WRF-Chem reader?
dz_m is the thickness of each layer, not height above ground level.

"height": "alt_msl_m_mid",
"height_agl": "alt_agl_m_mid",
"dz": "dz_m",

@blychs
Copy link
Contributor Author

blychs commented Oct 3, 2024

No, it doesn't. alg_agl_m_mid is the exact same thing here as in _wrfchem_mm. layer_height_agl was the layer height at the interface, which I was using later to create the thickness to calculate partial columns.
SInce the wrfchem reader went a different way, by calculating layer thickness in the reader, I am changing it to do the same, so that future code will work for both.
The TEMPO tool can already deal with the way that wrfchem does it.

@blychs
Copy link
Contributor Author

blychs commented Oct 3, 2024

That way, the TROPOMI tool (or any other) should work for both regardless, since the version loaded by MONETIO will look the same.

@zmoon
Copy link
Member

zmoon commented Oct 3, 2024

The NCDC website still having an issue, causing the test failures.

@zmoon zmoon merged commit 7c5ee66 into noaa-oar-arl:develop Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants