DOC: Specify py2k-compatible version in py3k statement #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `python>=3.6` requirement at the top of the file dates to early 2020, before v0.1 of MONETIO. Before this, MONET and MONETIO were one package. It looks like the last commit in MONET 2.1.5 merges in the work to split MONET and MONETIO, so someone wanting MONETIO functionality from MONET would need a MONET version prior to that.
zmoon
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Thanks @DWesl this is useful.
I wonder if we could include your reference to v2.1.5 as a footnote referenced here
to show that technically this was associated with v2.1.5 / noaa-oar-arl/monet#77, though v2.2.0 was the first GitHub Release. I can do this in MONET repo.
Thought I'd caught all of those, thanks for spotting that one. Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Like this? EDIT: Wrong repo. Should I leave it anyway? |
zmoon
reviewed
Nov 1, 2024
| @@ -7,7 +7,7 @@ air quality models. | |||
|
|
|||
| MONET was developed to evaluate the Community Multiscale Air Quality Model (CMAQ) | |||
| for the NOAA National Air Quality Forecast Capability (NAQFC) modeling system. | |||
| From MONET version 2.1.4, MONETIO was broken off from MONET to be its own dedicated repository. | |||
| From MONET version 2.1.4, MONETIO was broken off from MONET to be its own dedicated repository [#monetio-split]_. | |||
There was a problem hiding this comment.
To me this would make it slightly less ambiguous:
Suggested change
| From MONET version 2.1.4, MONETIO was broken off from MONET to be its own dedicated repository [#monetio-split]_. | |
| After MONET version 2.1.4, MONETIO was broken off from MONET to be its own dedicated repository [#monetio-split]_. |
Comment on lines
+91
to
+93
| .. [#monetio-split] The last commit of [MONET v2.1.5](https://github.com/noaa-oar-arl/monet/releases/tag/v2.1.5) | ||
| merged noaa-oar-arl/monet#77, which brought the branch testing the split MONET and MONETIO packages into the | ||
| primary branch of the repository. |
There was a problem hiding this comment.
Suggested change
| .. [#monetio-split] The last commit of [MONET v2.1.5](https://github.com/noaa-oar-arl/monet/releases/tag/v2.1.5) | |
| merged noaa-oar-arl/monet#77, which brought the branch testing the split MONET and MONETIO packages into the | |
| primary branch of the repository. | |
| .. [#monetio-split] The last commit of `MONET v2.1.5 <https://github.com/noaa-oar-arl/monet/releases/tag/v2.1.5>`__ | |
| merged `PR#77 <https://github.com/noaa-oar-arl/monet/pull/77>`__, which brought the branch testing the split MONET and MONETIO packages into the | |
| primary branch of the repository. | |
| The first official split GitHub releases with were `MONET v2.2.0 <https://github.com/noaa-oar-arl/monet/releases/tag/v2.2.0>`__ | |
| and `MONETIO v0.1 <https://github.com/noaa-oar-arl/monetio/releases/tag/v0.1>`__ (Mar 2020). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
python>=3.6requirement at the top of the file dates to early 2020, before v0.1 of MONETIO. Before this, MONET and MONETIO were one package. It looks like the last commit in MONET 2.1.5 merges in the work to split MONET and MONETIO, so someone wanting MONETIO functionality from MONET would need a MONET version prior to that.