-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross track point perturbation #122
Conversation
@WPringle I think the failed tests are due to wrong references. I'll do more testing on all the 3 storms from NHC, but can you check if you see anything wrong with the changes I made? |
@SorooshMani-NOAA Thanks for fix! Although it's strange since |
@WPringle I actually realized that later, but just wanted to be extra sure, the main fix was related to how 1 dim arrays where being incorrectly |
oh right, gotcha. think everything looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if things are fixed without adding abs() around alpha then maybe don't make this change as it makes you think this is the bug but it's actually the other lines..
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 21.29% 21.29%
=======================================
Files 28 28
Lines 3762 3762
=======================================
Hits 801 801
Misses 2961 2961 ☔ View full report in Codecov by Sentry. |
Fixes #118