Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.0.2 keeps crashing [bug] #988

Open
Lajota1 opened this issue Jun 6, 2024 · 23 comments
Open

V3.0.2 keeps crashing [bug] #988

Lajota1 opened this issue Jun 6, 2024 · 23 comments

Comments

@Lajota1
Copy link

Lajota1 commented Jun 6, 2024

Description

So MMF V3.0.2 keeps crashing and getting back all the time, mainly when a use the scroll wheel a lot. The app will stop working and the icon at the top will disappear, a few seconds later it will reappear and start to work again. Sonoma 14.5.

Steps to reproduce

1- Use the scroll wheel a lot

Context

Mac Mouse Fix Version: 3.0.2
macOS Version: Sonoma 14.5
Mouse Model: Viper V2 Pro

Additional Comments


Console Logs

void _updateToReflectAutomaticTerminationState(void) Setting _kLSApplicationWouldBeTerminatedByTALKey=1

Crash Reports

https://pastebin.com/YeeVjKZz

@plttn
Copy link

plttn commented Jun 6, 2024

Seeing this crashing still on my end as well.

I've had to switch to another scroll wheel reverser for the time being as it's nearly unusable. 😢

@Lajota1
Copy link
Author

Lajota1 commented Jun 7, 2024

Seeing this crashing still on my end as well.

I've had to switch to another scroll wheel reverser for the time being as it's nearly unusable. 😢

I bought the license but the crashes are so constant that its unusable. With one are you using?

@plttn
Copy link

plttn commented Jun 7, 2024

Seeing this crashing still on my end as well.
I've had to switch to another scroll wheel reverser for the time being as it's nearly unusable. 😢

I bought the license but the crashes are so constant that its unusable. With one are you using?

Given that this is a support forum for a product, I'm going to refrain from mentioning competitors, but there are absolutely other mouse wheel reversers in the market at the moment.

@cloudgazing
Copy link

Jumping in maybe I can help. The main version 3.0.2 has some issues and for now noah-nuebling released two more versions in #875. I'm on Sonoma 14.5 using a Razer Basilisk v3 and vcoba-2 has been almost flawless for me. Maybe you can try one of those, hopefully that fixes it.

@Lajota1
Copy link
Author

Lajota1 commented Jun 8, 2024

Jumping in maybe I can help. The main version 3.0.2 has some issues and for now noah-nuebling released two more versions in #875. I'm on Sonoma 14.5 using a Razer Basilisk v3 and vcoba-2 has been almost flawless for me. Maybe you can try one of those, hopefully that fixes it.

Been testing for a while, so far no crashes. Will update if crashes persist, thanks!

edit: so, unfortunately the crashes persist with vcoba-2, but it is more stable and the crashes happen less often. I'd say it is usable, but far from ideal.

edit 2: the standard vcoba (not the vcoba-2) is solid, working flawlessly until now, will test further and update if there are any crashes.

@plttn
Copy link

plttn commented Jun 12, 2024

vcoba2 seems to work well for me.

noah-nuebling added a commit that referenced this issue Jun 24, 2024
which disables asserts for non-release builds.
-> In 3.0.2, asserts were enabled the whole time, which contributed to a crash on
```
assert(tick <= _scrollConfig.consecutiveScrollTickIntervalMax);
```
inside Scroll.m. (See: #988)

- We also made some other slight adjustments to make the NDEBUG flag work (added exit(1) and returns in some places where before we only used assert(false))
- We also improved logging inside AccessibilityCheck.m
- Very slight doc improvements

TODO:
- Figure out how exactly the assert that caused #988 could become false
@noah-nuebling
Copy link
Owner

noah-nuebling commented Jun 24, 2024

Hey guys, thanks for your feedback!

I'm currently looking into this. I looked at the crash report and it seems the crash comes from this line of code according to my symbolication.

I've never ever seen this on my computer, and I'm just studying the code but it's really weird that this happens. Especially that you report "constant crashes", when I've never encountered this is strange.

I also don't understand why this would only happen on the v-coba builds.

I'm building some workarounds so the app can recover when it gets into this weird state, but hopefully I can figure out more.

@noah-nuebling
Copy link
Owner

Also I have some questions, that might help get to the bottom of this:

  • Do you guys frequently use the "Swift Scroll" modifier?
  • Do the crashes typically happen when your computer is really slow?
  • What computer model are you guys using?
  • Any other patterns you noticed about when the crashes happen?

If someone else with the issue can share their crash reports that would also be really interesting. The one from @Lajota1 has already been very helpful.

@noah-nuebling
Copy link
Owner

noah-nuebling commented Jun 24, 2024

Oh and if you guys want I'd like to give anyone affected by this a refund. Just shoot me an email.

@plttn
Copy link

plttn commented Jun 24, 2024

@noah-nuebling to clarify, the crashing doesn't occur on vcoba builds for me.

You should also have crash logs submitted by me from April 2, 2024.

@noah-nuebling
Copy link
Owner

noah-nuebling commented Jun 24, 2024

Hey @plttn, thanks for getting back. That's interesting that you don't have the issue on the vcoba-2 build, but @Lajota1 still experiences crashes on vcoba-2. Thanks for clarifying that.

I looked at your crash report and it's consistent with the one that @Lajota1 shared. So that's also very helpful.

@plttn
Copy link

plttn commented Jun 24, 2024

To answer the questions:

Do you guys frequently use the "Swift Scroll" modifier?

Never

Do the crashes typically happen when your computer is really slow?

As far as I'm aware no, (also because my Mac is a 64 gig of RAM model)

What computer model are you guys using?

M1 Max 2TB/64GB

Any other patterns you noticed about when the crashes happen?

Just scrolling is enough to cause it to crash.

@noah-nuebling
Copy link
Owner

@plttn thanks for getting back!

Are you guys using the Smoothness: Regular setting?

@plttn
Copy link

plttn commented Jun 25, 2024

@plttn thanks for getting back!

Are you guys using the Smoothness: Regular setting?

I'm using Smoothness: High

@noah-nuebling
Copy link
Owner

@plttn oh that's very interesting!

From my understanding so far, I thought the crash happens inside code that is only executed when using Smoothness: Regular. Have you been using Smoothness: Regular around the time you experienced the crash that you sent to me?

@plttn
Copy link

plttn commented Jun 25, 2024

@plttn oh that's very interesting!

From my understanding so far, I thought the crash happens inside code that is only executed when using Smoothness: Regular. Have you been using Smoothness: Regular around the time you experienced the crash that you sent to me?

As far as I know I've been using smoothness high since it released.

noah-nuebling added a commit that referenced this issue Jun 25, 2024
….0.2 scrolling crashes described in #988. Also did minimal cleanup, logging improvements, and doc improvements.
@mhaeuser
Copy link

Same issue here, definitely using Smoothness High (and Trackpad Simulation, macOS speed, inverse direction). I'm on M3 Pro. The issue started happening yesterday out of the blue, I haven't had anything alike since I started using Mac Mouse Fix (still in the v2 era). I sometimes use SHIFT-scrolling, but it is not required to trigger the bug.

I see you pushed workarounds to recover from the bug - any idea when you might release it? Thanks!

@plttn
Copy link

plttn commented Aug 23, 2024

@noah-nuebling any plans to release a non-beta version with these fixes yet? I've been stuck on 3.0.2-vcoba2 since my initial crash reports.

@noah-nuebling
Copy link
Owner

noah-nuebling commented Sep 18, 2024

Hey guys, I plan to release a fix tonight or tomorrow with the 3.0.3 release!

I was working on improving the localization system across the project, and I sort of got tunnel-visioned on that. I'm really sorry it took me so long to address this.

I've never experienced this crash even though I tried to reproduce it to catch it in the debugger for a while. And I'm still not sure what could lead to the internal conditions in the app that caused the crash. But if those conditions occur, the app should smoothly recover under 3.0.3 instead of crashing.

For now, the workaround in 3.0.3 should work ok, but if I want to work on the scrolling system in the future, it might be really valuable to understand this better.

If anybody's still experiencing these crashes (or if you did still experience them when you were last using 3.0.2) it would be really valuable if you sent your config.plist file so I can have a look at it.

The config.plist file holds pretty much all settings and state that is retained between launches of the app. You can find it like this:

  1. Open Mac Mouse Fix
  2. Go to the 'About' tab
  3. Click the Mac Mouse Fix Icon while holding Command (⌘) and Shift (⇧). This should reveal the 'config.plist' file in the Finder.

Thank you, for your help.

@mhaeuser
Copy link

Thanks for the update! Is there any chance a macOS bug or odd behaviour could be contributing? I cannot reproduce the issue on macOS 15.1 Beta 4 right now (on 3.0.2 of course).

@noah-nuebling
Copy link
Owner

noah-nuebling commented Sep 20, 2024

@mhaeuser That's an definitely a possibility that I hadn't considered before. It would be very interesting to hear whether you start seeing the crashes again, or whether it stays crash-free under 15.1.

@mxalbert1996
Copy link

I experienced crashes on 3.0.2, so here's my config.plist.
config.plist.zip

@noah-nuebling
Copy link
Owner

@mxalbert1996 I can't spot anything weird with that config.plist file after a quick check, but I'll use it with 3.0.2 for a while to see if I might be able to reproduce the crashes. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants